Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable AutoCLI for x/accounts #21953

Open
julienrbrt opened this issue Sep 27, 2024 · 7 comments
Open

Enable AutoCLI for x/accounts #21953

julienrbrt opened this issue Sep 27, 2024 · 7 comments

Comments

@julienrbrt
Copy link
Member

x/accounts still uses old style CLI (booo), we should check if AutoCLI needs feature to support x/accounts use case and remove those manual CLI from accounts.

https://github.com/cosmos/cosmos-sdk/blob/main/x/accounts/cli/cli.go#L1-L205

@julienrbrt julienrbrt self-assigned this Sep 27, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK Sep 27, 2024
@julienrbrt
Copy link
Member Author

suggestions from @Reecepbcups:

  • query for all account types
  • query for all account types msg / query implementation

@DongLieu
Copy link
Contributor

DongLieu commented Dec 2, 2024

Can I solve this issue?

@julienrbrt julienrbrt removed their assignment Dec 2, 2024
@julienrbrt
Copy link
Member Author

julienrbrt commented Dec 2, 2024

Feel free to tackle this yeah, thanks! Haven't checked the path on how to do it nicely, so let's maybe talk about the design here first.

We probably need to add a feature in AutoCLI to do json to proto. Probably with a proto tag or something in the module protos.
AutoCLI should generally adapt, but not have any x/accounts specific logic. That was my rough idea, but we can discuss that more here if you thought of something else.

@DongLieu
Copy link
Contributor

DongLieu commented Dec 2, 2024

My idea is to change the proto message:
Image

And similarly for MsgExecute and MsgInit:
Image
Image

@DongLieu
Copy link
Contributor

DongLieu commented Dec 2, 2024

And add a new func in encoding
Image

@julienrbrt
Copy link
Member Author

So x/accounts is doing the encoding instead of the client? That would make client life easier yeah (and not only AutoCLI)
@testinginprod what do you think?

@DongLieu
Copy link
Contributor

DongLieu commented Dec 3, 2024

I have created PR for this, if that idea is not approved by @testinginprod I will close it. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📋 Backlog
Development

Successfully merging a pull request may close this issue.

2 participants