-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable AutoCLI for x/accounts #21953
Comments
suggestions from @Reecepbcups:
|
Can I solve this issue? |
Feel free to tackle this yeah, thanks! Haven't checked the path on how to do it nicely, so let's maybe talk about the design here first. We probably need to add a feature in AutoCLI to do json to proto. Probably with a proto tag or something in the module protos. |
So x/accounts is doing the encoding instead of the client? That would make client life easier yeah (and not only AutoCLI) |
I have created PR for this, if that idea is not approved by @testinginprod I will close it. Thanks |
x/accounts still uses old style CLI (booo), we should check if AutoCLI needs feature to support x/accounts use case and remove those manual CLI from accounts.
https://github.com/cosmos/cosmos-sdk/blob/main/x/accounts/cli/cli.go#L1-L205
The text was updated successfully, but these errors were encountered: