[Bug]: server/v2/stf always returns TxResult.Code = 0

[kocubinski]

Is there an existing issue for this?

• I have searched the existing issues

What happened?

This was surfaced while adapting integration tests for server/v2. STF.deliverTx always returns TxResult.Code as the default value (0) regardless of transactions execution status. Relevant code snippet below.

cosmos-sdk/server/v2/stf/stf.go

Lines 206 to 213 in bc3ddfa

	execResp, execGas, execEvents, err := s.execTx(ctx, state, gasLimit-validateGas, tx, execMode, hi)
	return server.TxResult{
	Events: append(validationEvents, execEvents...),
	GasUsed: execGas + validateGas,
	GasWanted: gasLimit,
	Resp: execResp,
	Error: err,
	}

Cosmos SDK Version

main

How to reproduce?

run a failing transaction, the result should be non zero and contain the correct error code as defined in cosmossdk.io/error

[julienrbrt]

As just discussed in our runtime sync, we'll remove Code from TxResult, as the consensus is filling it (by parsing the abci error from the error being returned)