Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark more queries with module_query_safe #20219

Open
srdtrk opened this issue Apr 30, 2024 · 2 comments · May be fixed by #22095
Open

Mark more queries with module_query_safe #20219

srdtrk opened this issue Apr 30, 2024 · 2 comments · May be fixed by #22095
Assignees
Labels
good first issue T: Dev UX UX for SDK developers (i.e. how to call our code)

Comments

@srdtrk
Copy link
Member

srdtrk commented Apr 30, 2024

Summary

Mark all x/distribution and x/gov queries with the module_query_safe tag to allow them to be queries by interchain accounts.

Problem Definition

Currently, all (or most) of x/bank, x/staking, x/auth, x/circuit queries are marked with the module_query_safe tag. In interchain accounts, we only allow module_query_safe queries to be executed across chains since the query results are written to the packet acknowledgement. Our users would like would like to have x/distribution and x/gov queries enabled. It'd be nice to look into what other modules can be enabled as well.

This was also suggested in this closed issue.

Proposed Feature

Add this line to the mentioned queries and add tests if needed.

@Teyz
Copy link
Contributor

Teyz commented Oct 1, 2024

Can I get this issue ? @julienrbrt

@julienrbrt
Copy link
Member

Can I get this issue ? @julienrbrt

Of course, thank you!

Teyz added a commit to Teyz/cosmos-sdk that referenced this issue Oct 3, 2024
@Teyz Teyz linked a pull request Oct 3, 2024 that will close this issue
12 tasks
Teyz added a commit to Teyz/cosmos-sdk that referenced this issue Oct 3, 2024
Teyz added a commit to Teyz/cosmos-sdk that referenced this issue Oct 3, 2024
Teyz added a commit to Teyz/cosmos-sdk that referenced this issue Oct 4, 2024
Teyz added a commit to Teyz/cosmos-sdk that referenced this issue Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue T: Dev UX UX for SDK developers (i.e. how to call our code)
Projects
Status: 📋 Backlog
3 participants