Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Events and Compatibility with upcoming release Igor #159

Open
splitbrain opened this issue Nov 10, 2021 · 3 comments
Open

Form Events and Compatibility with upcoming release Igor #159

splitbrain opened this issue Nov 10, 2021 · 3 comments

Comments

@splitbrain
Copy link
Member

This plugin seems to make use of one or more form related action events that will be removed in the next DokuWiki release. Please have a look at https://www.patreon.com/posts/better-forms-58551930 for details.

My apologies if this has already been addressed in your code. If you have any questions on how to implement the needed changes please let me know.

@mtkirchner
Copy link

I am using the plugin.

I cannot find a mention of HTML_RECENTFORM_OUTPUT

HTML_REVISIONSFORM_OUTPUT is used once. There is no use of the replacement FORM_REVISIONS_OUTPUT, so I guess the plugin has not been adaped. Is someone working on it?

@Klap-in
Copy link
Contributor

Klap-in commented Jan 6, 2022

HTML_RECENTFORM_OUTPUT

$controller->register_hook('HTML_RECENTFORM_OUTPUT', 'BEFORE', $this, 'handle_recent', array());

This is replaced by the event FORM_RECENT_OUTPUT. This means an extra event handler should be added which listens to the new event, and executes a copy of handle_recent(), but which should use the new Form, not the old Doku_Form.

HTML_REVISIONSFORM_OUTPUT

$controller->register_hook('HTML_REVISIONSFORM_OUTPUT', 'BEFORE', $this, 'handle_revisions', array());

This is replaced the event FORM_REVISIONS_OUTPUT. This means an extra event handler should be added which listens to the new event, and executes a copy of handle_revisions(), but which should use the new Form.

I think no one is working on this yet, so feel free to take this task.

@mtkirchner
Copy link

Thanks. As I am not a programmer, I am unsure if this is something I should start. At the moment I also do not have the devel-environment or the git checkout. Without a step-by-step manual I would not try my luck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants