-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: add filter who is allowed to use DokuWiki #127
Comments
@igittigitt why don't you share your code as pull request then? |
I am also interested in this feature for the very same case. |
Some more notes and considerations down here: I fear, that there is no way to satisfy every condition because:
|
I'm in that situation and solved it by removing all permissions using ACLs from @systemofapwne You should at least be able to control the IdP or the DokuWiki ACLs. So you either add the matching groups or match them in the ACLs. @igittigitt could just the ACLs for the Apart from having the users in the local user database I don't see any issues. |
This may be only a special requirement for those running their own IAM, but especially there it is most needed.
If a user has authenticated through an IAM he will end up in DokuWiki with an user created and maybe some access (depends on the setup). For companies this is bad, as they need to control which one uses which application (e.g. DokuWiki).
Therefore i hacked the plugin to only successfully login a user if his groups (added a "group" claim to the oidc-client DokuWiki uses) contain a special usage-group (i've called it "DokuWiki_Users") in the IdP-payload. If this group-membership is not found, i add an errormessage telling the user that he is not entitled to use this service.
I'm really looking forward to have this incorporated into the plugin itself, even if using it in companies is just an edge-case.
What i've done with groups may also be done with roles from the IAM, or some other attribute in the payload of the IdP. So it might be wise to make this widely configureable. This is why i used "filter" in my request instead of "group-membership".
Very important in my opinion would be to have a custom action for the case a user does not match the requirement, e.g. simply show a page whith an custom message coming from a DokuWiki-page source. For me it seems important that this errormessage only shows the pages content and not the whole framework of DokuWiki. Another custom action could be to redirect to an URL instead.
The text was updated successfully, but these errors were encountered: