feat: implement correct watch restart for controller runtime #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Controller runtime does `WatchKind` on all controller input resources, but initial bookmark value is only delivered if there is any update received (on each of the watches). If resource cache is used, `BootstrapContents` will deliver the bookmark, but if the cache is not used, and there are no updates, no bookmark is ever sent, so watch can't be restarted. Fix this by adding yet another option to send 'Noop' events which carry only the bookmark allowing watch retry code to handle it. Signed-off-by: Andrey Smirnov <[email protected]>
|
Uses cosi-project/specification#14 I will do a similar change to |
frezbo
approved these changes
Dec 27, 2024
utkuozdemir
approved these changes
Dec 27, 2024
|
/m |
smira
added a commit
to smira/state-etcd
that referenced
this pull request
Dec 27, 2024
Catch up with cosi-project/runtime#543 Signed-off-by: Andrey Smirnov <[email protected]>
smira
added a commit
to smira/state-etcd
that referenced
this pull request
Dec 27, 2024
Catch up with cosi-project/runtime#543 Signed-off-by: Andrey Smirnov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Controller runtime does
WatchKindon all controller input resources, but initial bookmark value is only delivered if there is any update received (on each of the watches).If resource cache is used,
BootstrapContentswill deliver the bookmark, but if the cache is not used, and there are no updates, no bookmark is ever sent, so watch can't be restarted.Fix this by adding yet another option to send 'Noop' events which carry only the bookmark allowing watch retry code to handle it.
Fixes #540