Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Splitting Endpoints of Verification Controller #104

Closed
anjeyy opened this issue May 30, 2020 · 2 comments · Fixed by #184 or #206
Closed

Splitting Endpoints of Verification Controller #104

anjeyy opened this issue May 30, 2020 · 2 comments · Fixed by #184 or #206
Assignees
@ascheibal
Labels
enhancement New feature or request in progress The issue is currently being resolved

Comments

@anjeyy
Copy link

anjeyy commented May 30, 2020

Current Implementation

  • Currently VerificationController has multiple Endpoints which do different things.

Suggested Enhancement

  • Split content of VerificationController into (for example) three different controllers. Naturally seperated by given Endpoints. (RegistrationTokenController, TestresultController, TanController)

Expected Benefits

  • Splitting up gives better encapsulation for different actions beeing performed. (SRP)
  • Further it benefits for Avoid layer packages #60 but even if you keep the package layers it benefits the structure and readybility.

I think it is a good first issue for new people looking forward to contribute. (I know me included. ☺️ )
@anjeyy anjeyy added the enhancement New feature or request label May 30, 2020
@anjeyy anjeyy changed the title VerificationController seems a bit overloaded Splitting Endpoints of Verification Controller May 30, 2020
@Schnix1328 Schnix1328 added the in review Moderators are investigating how to best proceed with the issue label May 30, 2020
@f11h
Copy link
Member

f11h commented Jun 26, 2020

Hi @anjeyy,
your request will be implemented in the feat/split-internal-and-external-endpoints branch (c935434)

@f11h f11h added the in progress The issue is currently being resolved label Jun 26, 2020
@dfischer-tech dfischer-tech linked a pull request Jul 13, 2020 that will close this issue
feat: split internal and external endpoints #184
Merged
@daniel-eder daniel-eder removed the in review Moderators are investigating how to best proceed with the issue label Jul 17, 2020
@ascheibal ascheibal linked a pull request Aug 11, 2020 that will close this issue
fix: ssl deactivation for live & readiness probes #206
Merged
@ascheibal
Copy link
Contributor

Hi @anjeyy, we finally made this available with version 1.2/1.3 of the verification server. Thanks for contributing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ascheibal ascheibal

Labels
enhancement New feature or request in progress The issue is currently being resolved
Projects
None yet
Milestone
No milestone
5 participants
@daniel-eder @Schnix1328 @f11h @ascheibal @anjeyy