You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, the tagger doesset(coreos-pool) - set(lockfile-packages) to know which builds to tag into the intermediate (signing) tag. And then it waits for 10m for the builds to get signed. However, as we'veseen, 10m might not be long enough.
ISTM how long RoboSignatory takes to sign packages shouldn't affect coreos-koji-tagger. Instead of waiting for the build to be signed, instead it should do (set(coreos-pool) U set(f31-coreos-signing-pending)) - set(lockfile-packages). I.e. it should consider packages in queue to be signed as if they're already tagged. That should simplify its logic and make it indifferent to how busy RoboSignatory is.
The text was updated successfully, but these errors were encountered:
we must wait until the package is signed before requesting a new distrepo (yum repo). Otherwise the yum repo won't have the package in it.
Ahh right, that's an important detail.
Hmm, I think then what we could do is have a separate thread that just waits for the signing tag to be empty before starting a new distRepo task. IOW, we completely decouple those two parts of the app. That way for example the tagger can just keep processing messages while RoboSignatory is busy, and we'll get to regenerating the repo once it gets to our requests. But yeah, that increases complexity.
Right now, the tagger does
set(coreos-pool) - set(lockfile-packages)
to know which builds to tag into the intermediate (signing) tag. And then it waits for 10m for the builds to get signed. However, as we've seen, 10m might not be long enough.ISTM how long RoboSignatory takes to sign packages shouldn't affect coreos-koji-tagger. Instead of waiting for the build to be signed, instead it should do
(set(coreos-pool) U set(f31-coreos-signing-pending)) - set(lockfile-packages)
. I.e. it should consider packages in queue to be signed as if they're already tagged. That should simplify its logic and make it indifferent to how busy RoboSignatory is.The text was updated successfully, but these errors were encountered: