Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No pull request trace span attributes recorded when triggering on "workflow_run" #14

Open
seh opened this issue Jun 4, 2024 · 7 comments

Comments

@seh
Copy link

seh commented Jun 4, 2024

The project's documentation recommends triggering a workflow using this action to run upon receiving the "workflow_run" GitHub event. However, when I do so, I notice that none of my trace spans include any of the "github.pull_requests.*" trace span attributes mentioned in the documentation.

Should these attributes be available for such events? I see that the action looks for whether the workflow job references any pull requests, and I have this action recording traces for GitHub Actions workflows of mine that trigger upon "pull_request" events. Can this action not see "through" the event it receives to what happened with the job it's transcribing later?

@corentinmusard
Copy link
Owner

Thank you for your comment. I'll investigate this issue this week.

Did you try the 2nd method (adding it inside an existing workflow) ?

@seh
Copy link
Author

seh commented Jun 10, 2024

Did you try the 2nd method (adding it inside an existing workflow) ?

Not with this action, but that's how I used to use the upstream fork. I figured that when I switched to use this fork, I'd also stop repeating the job definition in each of the workflows that I wanted to instrument.

@seh
Copy link
Author

seh commented Sep 6, 2024

Should we consider the currently recommended approach to no longer be the right idea? After using it for several months, I'm dissatisfied both by all of the workflow run records posted to the repositories actions page, and by the lack of pull request-related details in resulting traces.

@seh
Copy link
Author

seh commented Sep 18, 2024

Having changed my workflows to include this action in a final job within each workflow, I'm still finding no span attributes with names including the word "pull_request", despite what's mentioned in the documentation.

The triggering event for my workflow run is "pull_request". What might be going wrong here?

@seh
Copy link
Author

seh commented Sep 19, 2024

I discovered that for pull requests initiated from branches within the same GitHub repository as the target branch, we do get these PR-related span attributes. It seems that either GitHub is not making these details available for PRs initiated from branches in forked repositories, or the details sit in a different place in the data this action is retrieving from the GitHub API.

@seh
Copy link
Author

seh commented Sep 19, 2024

See the "community" discussion 25220 for coverage of this omission.

@corentinmusard
Copy link
Owner

Hey,
Sorry, I don't have the bandwidth to work on this project anymore.
I'm quite busy with life at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants