Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79
This will remove
ONLY_FULL_GROUP_BY
from the@@sql_modes
only ifMYSQL_ROOT_PASSWORD
is defined as an env var for the misp container.Changing this global setting requires a root account, so I've added
MYSQL_ROOT_PASSWORD
as an optional var on the misp container. Maybe it should be default for this compose file?The alternative is to define add
--sql-mode="STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION"
to the
db
container command. This may be simpler and not require exposing the root DB password to misp, but we'll need to track any changes or updates to the defaults, and it doesn't help if using an external DB (perhaps that can just be covered in documentation?).Ideally this is all fixed upstream so we don't have to mess with the DB defaults.