Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade kryo-tools #790

Open
abyrd opened this issue Feb 25, 2022 · 1 comment
Open

Upgrade kryo-tools #790

abyrd opened this issue Feb 25, 2022 · 1 comment

Comments

@abyrd
Copy link
Member

abyrd commented Feb 25, 2022

Conveyal's kryo-tools project is shared between R5 and OTP. OTP2 needed to upgrade Kryo and some other dependencies (conveyal/kryo-tools#7), so we built a new version of kryo-tools and deployed it to Sonatype OSSRH. R5 should try using this updated set of dependencies and see if we run into any problems. If not, it is probably a good idea to keep these dependencies aligned with OTP and kryo-tools, so we should make a new tagged release of kryo-tools and update R5 to use it.

The Kryo upgrade may be related to / interact with moving to newer Java versions (R5 #760).

Confirmed in discussion with @leonardehrenfried: the primary reasons for the upgrade are that Kryo 5 has built in serializers for Set.of() List.of() etc. and we hopefully can get rid some of the third party serializers like javakaffee.

@leonardehrenfried
Copy link

One thing I neglected to say is that Kryo 5 has built in support for Java 17 records which we plan to start using in OTP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants