feat(cxl-ui): decrease instructor bio font size #407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoblet
force-pushed
the
anoblet/feat/instructor
branch
from
a80df6f to
14f7bf2
Compare
size-limit report 📦
|
pawelkmpt
requested changes
Apr 26, 2024
|
The majority of the devices used on our site, are above 360px. @pawelkmpt and I both took a look in GA, and came to the conclusion that supporting 320px is not needed. |
pawelkmpt
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Looking good 👍
I just noticed .instructor-bio styles are inlined in View so added this rule there: https://cxl.com/institute/wp-admin/admin.php?page=views-editor&view_id=1218087
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.clickup.com/t/86b070d0a