Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cxl-ui): [cxl-certificate-header] update completed page #399

Merged
merged 1 commit into from
Mar 4, 2024
Merged

feat(cxl-ui): [cxl-certificate-header] update completed page #399

merged 1 commit into from
Mar 4, 2024

Conversation

anoblet
Copy link
Collaborator

@anoblet anoblet commented Feb 21, 2024 •
edited
Loading

@anoblet anoblet requested review from lkraav and pawelkmpt February 21, 2024 14:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 72.35 KB (+0.04% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.89 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 29.04 KB (0%)
packages/cxl-ui/pkg/dist-web/vendor.js 140.5 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 254.94 KB (+0.02% 🔺)

@anoblet anoblet force-pushed the anoblet/feat/completed branch from 640b4f9 to 475426e Compare February 22, 2024 14:06
pawelkmpt
pawelkmpt reviewed Feb 23, 2024
View reviewed changes
Copy link

@pawelkmpt pawelkmpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anoblet why solution with MediaQueryController controller is better than simply hiding credential with CSS?

Especially in situation when _wideMediaQuery = '(min-width: 528px)'; is different from CSS MQ values (closest: $small: 568px).

@pawelkmpt
Copy link

@anoblet why solution with MediaQueryController controller is better than simply hiding credential with CSS?

Especially in situation when _wideMediaQuery = '(min-width: 528px)'; is different from CSS MQ values (closest: $small: 568px).

@anoblet ping

@anoblet anoblet force-pushed the anoblet/feat/completed branch from 475426e to a3299fd Compare February 28, 2024 13:28
@anoblet anoblet requested a review from pawelkmpt February 28, 2024 13:29
@anoblet
Copy link
Collaborator Author

anoblet commented Feb 28, 2024

@pawelkmpt True. I was unsure which was the best strategy. Updated :)

pawelkmpt
pawelkmpt requested changes Mar 1, 2024
View reviewed changes
Copy link

@pawelkmpt pawelkmpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anoblet credential picture is suppose to be hidden on mobile and visible from medium. Buttons should be always visible though.

@anoblet anoblet force-pushed the anoblet/feat/completed branch 3 times, most recently from 81d332b to 7a09568 Compare March 1, 2024 13:38
@anoblet anoblet requested a review from pawelkmpt March 1, 2024 13:49
@pawelkmpt pawelkmpt force-pushed the anoblet/feat/completed branch from 7a09568 to 8fdc043 Compare March 4, 2024 10:49
@pawelkmpt pawelkmpt force-pushed the anoblet/feat/completed branch from 8fdc043 to 45dd30b Compare March 4, 2024 10:49
@pawelkmpt pawelkmpt merged commit 6f63f36 into master Mar 4, 2024
5 checks passed
@pawelkmpt pawelkmpt deleted the anoblet/feat/completed branch March 4, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelkmpt pawelkmpt pawelkmpt approved these changes

@lkraav lkraav Awaiting requested review from lkraav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anoblet @pawelkmpt