Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cxl-lumo-styles): add button pending state #397

Merged
merged 1 commit into from
Feb 23, 2024
Merged

feat(cxl-lumo-styles): add button pending state #397

merged 1 commit into from
Feb 23, 2024

Conversation

anoblet
Copy link
Collaborator

@anoblet anoblet commented Feb 20, 2024

@anoblet anoblet requested review from lkraav and pawelkmpt February 20, 2024 14:25
@anoblet anoblet mentioned this pull request Feb 20, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 72.13 KB (+0.17% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.89 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 29.04 KB (+0.43% 🔺)
packages/cxl-ui/pkg/dist-web/vendor.js 140.5 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 254.71 KB (+0.1% 🔺)

pawelkmpt
pawelkmpt reviewed Feb 20, 2024
View reviewed changes
Copy link

@pawelkmpt pawelkmpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://deploy-preview-397--conversionxl-aybolit.netlify.app/?path=/story/cxl-lumo-styles-elements--vaadin-button

For some reason shows spinner only
Screenshot 2024-02-20 at 16 41 28

@anoblet
Copy link
Collaborator Author

anoblet commented Feb 20, 2024

@pawelkmpt I had an issue at first that was fixed by reloading the page. This is what I see in Incognito now:

image

@anoblet anoblet force-pushed the anoblet/feat/action branch from 939a2cc to b853b14 Compare February 20, 2024 22:51
@anoblet anoblet force-pushed the anoblet/feat/action branch from b853b14 to 28cc73e Compare February 21, 2024 00:55
@pawelkmpt pawelkmpt merged commit 9debcbc into master Feb 23, 2024
5 checks passed
@pawelkmpt pawelkmpt deleted the anoblet/feat/action branch February 23, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelkmpt pawelkmpt pawelkmpt approved these changes

@lkraav lkraav lkraav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anoblet @lkraav @pawelkmpt