-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cxl-ui): light-card layout updates #353
Conversation
size-limit report 📦
|
c94a1b0
to
917f4ce
Compare
@pawelkmpt After @freudFlintstone comments under the second PR, I did it the way it was originally intended. There was some miscommunication. The second PR can be deleted once it's accepted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b5e1ee4
to
b8f887d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HenerHoop cards itself are looking good. I just found few inconsistencies comparing to the design
1. Portrait card
Prevent image corner to leak out the box
2. Three lines title
Design shows 3 lines in the title.
3. Card in progress
Design hides instructor name on "in progress" card.
Our card still shows it.
4. Extreme lengths
Design and comment suggest card to grow for extreme cases
Our looks like this:
b8f887d
to
2e250bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message
- feat(cxl-ui): light-card layout updates
+ feat(cxl-ui): cxl-light-card add portrait mode, progress bar
2e250bf
to
dcb3e24
Compare
Task linked: CU-86ayhhg16 Lite card component layouts |
https://app.clickup.com/t/86ayhhg16