Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cxl-ui): light-card layout updates #353

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

HenerHoop
Copy link

@github-actions
Copy link

github-actions bot commented Oct 28, 2023

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 64.04 KB (+0.62% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.87 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 27.69 KB (+0.09% 🔺)
packages/cxl-ui/pkg/dist-web/vendor.js 135.58 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 240.33 KB (+0.18% 🔺)

@HenerHoop HenerHoop force-pushed the hener/feat/light-card/layout-updates branch from c94a1b0 to 917f4ce Compare October 28, 2023 14:29
@HenerHoop HenerHoop marked this pull request as ready for review October 28, 2023 14:38
@HenerHoop
Copy link
Author

@pawelkmpt After @freudFlintstone comments under the second PR, I did it the way it was originally intended. There was some miscommunication. The second PR can be deleted once it's accepted.

Copy link

@freudFlintstone freudFlintstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only issue I found is that the instructor name is aligned to the bottom in the designs. Other than that, great turn around on this one, I agree the other PR should be canceled.
image

@HenerHoop HenerHoop force-pushed the hener/feat/light-card/layout-updates branch 2 times, most recently from b5e1ee4 to b8f887d Compare October 30, 2023 08:25
Copy link

@pawelkmpt pawelkmpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HenerHoop cards itself are looking good. I just found few inconsistencies comparing to the design

1. Portrait card

Prevent image corner to leak out the box

Screenshot 2023-10-31 at 09 59 04


2. Three lines title

Design shows 3 lines in the title.
Screenshot 2023-10-31 at 10 04 35

Our card displays just 2.
Screenshot 2023-10-31 at 10 03 27


3. Card in progress

Design hides instructor name on "in progress" card.

Screenshot 2023-10-31 at 10 04 35

Our card still shows it.


4. Extreme lengths

Design and comment suggest card to grow for extreme cases

Screenshot 2023-10-31 at 10 14 17

Our looks like this:

Screenshot 2023-10-31 at 10 06 40

@HenerHoop HenerHoop force-pushed the hener/feat/light-card/layout-updates branch from b8f887d to 2e250bf Compare October 31, 2023 09:38
@HenerHoop HenerHoop requested a review from pawelkmpt October 31, 2023 09:38
Copy link

@pawelkmpt pawelkmpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message

- feat(cxl-ui): light-card layout updates
+ feat(cxl-ui): cxl-light-card add portrait mode, progress bar

@HenerHoop HenerHoop force-pushed the hener/feat/light-card/layout-updates branch from 2e250bf to dcb3e24 Compare October 31, 2023 10:28
@HenerHoop HenerHoop requested a review from pawelkmpt October 31, 2023 10:31
@pawelkmpt
Copy link

Task linked: CU-86ayhhg16 Lite card component layouts

@pawelkmpt pawelkmpt merged commit 82b720e into master Oct 31, 2023
4 checks passed
@pawelkmpt pawelkmpt deleted the hener/feat/light-card/layout-updates branch October 31, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants