Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Remove Index type #289

Open
jbcaillau opened this issue Sep 7, 2024 · 3 comments
Open

[Feature] Remove Index type #289

jbcaillau opened this issue Sep 7, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@jbcaillau
Copy link
Member

jbcaillau commented Sep 7, 2024

  • remove from constraint ranges
  • replace by Base.RefValue{Int64} for free initial / fine time
@jbcaillau jbcaillau added the enhancement New feature or request label Sep 7, 2024
@jbcaillau jbcaillau self-assigned this Sep 7, 2024
@jbcaillau
Copy link
Member Author

@PierreMartinon please remind me whether you use Index type in CTDirect.jl. possibly to test whether t0 or tf are free.

@ocots
Copy link
Member

ocots commented Sep 10, 2024

Pierre does not use Index. We have getters now. See https://github.com/search?q=repo%3Acontrol-toolbox%2FCTDirect.jl%20has_free_initial_time&type=code

@jbcaillau
Copy link
Member Author

@ocots indeed, only trace of Index in test/old. @PierreMartinon do you confirm?

1d [jcaillau@nef-devel2:~/CTDirect.jl]└5 [dev] main ± cd src
1d [jcaillau@nef-devel2:~/CTDirect.jl/src]└5 [dev] main ± ls
ctbase.jl  CTDirect.jl  default.jl  gauss.jl  midpoint.jl  problem.jl  solution.jl  solve.jl  trapeze.jl  utils.jl
1d [jcaillau@nef-devel2:~/CTDirect.jl/src]└5 [dev] main ± grep Index *.jl
1d [jcaillau@nef-devel2:~/CTDirect.jl/src]└5 [dev] main 1 ± ls
ctbase.jl  CTDirect.jl  default.jl  gauss.jl  midpoint.jl  problem.jl  solution.jl  solve.jl  trapeze.jl  utils.jl
1d [jcaillau@nef-devel2:~/CTDirect.jl/src]└5 [dev] main ± cd ../test/
1d [jcaillau@nef-devel2:~/CTDirect.jl/test]└5 [dev] main ± ls
deps.jl         old/       Project.toml    runtests.jl       solution_test.jld2  suite/
manual_test.jl  problems/  refine_grid.jl  scalar_vector.jl  solution_test.json
1d [jcaillau@nef-devel2:~/CTDirect.jl/test]└5 [dev] main ± !gr
grep Index *.jl
1d [jcaillau@nef-devel2:~/CTDirect.jl/test]└5 [dev] main 1 ± cd old/
1d [jcaillau@nef-devel2:~/CTDirect.jl/test/old]└5 [dev] main ± grep Index *.jl
bocop_goddard.jl:constraint!(ocp, :control, Index(1), 0, 1, :box_control)
local_test_exponential.jl:time!(ocp2, 0, Index(1))
local_test_exponential.jl:time!(ocp3, 0, Index(1))
local_test_exponential.jl:#time!(ocp3, Index(1), Index(2))
1d [jcaillau@nef-devel2:~/CTDirect.jl/test/old]└5 [dev] main ± cd ../problems/
1d [jcaillau@nef-devel2:~/CTDirect.jl/test/problems]└5 [dev] main ± !g
grep Index *.jl
1d [jcaillau@nef-devel2:~/CTDirect.jl/test/problems]└5 [dev] main 1 ± 

@ocots ocots linked a pull request Sep 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants