update workflow traces #658
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sallyom
requested review from
MichaelClifford,
rhatdan,
lmilbaum,
cgwalters and
Gregory-Pereira
as code owners
Signed-off-by: sallyom <[email protected]>
sallyom
force-pushed
the
workflow-traces-update
branch
4 times, most recently
from
aff1830 to
ef64c26
Compare
Signed-off-by: sallyom <[email protected]>
sallyom
force-pushed
the
workflow-traces-update
branch
from
ef64c26 to
f290233
Compare
|
wait for this to merge before reviewing: #660 |
|
I just resolved conflicts by including your changes, which caused CI issues, going to TAL |
Gregory-Pereira
force-pushed
the
workflow-traces-update
branch
from
9389041 to
f290233
Compare
|
reverted my merge commit for now |
|
After reviewing the conflicts again I don't think the merge commit was the issue. I will allow you to resolve them to verify. |
|
Needs a rebase. |
|
Closing since this has not moved in many months, re-open if this is still needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #660
cleanup of workflow traces - testing-workflow traces were broken, not configured correctly