-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing passing port as a build argument to containers #258
fixing passing port as a build argument to containers #258
Conversation
ccf8cd9
to
49a71d3
Compare
Note: I chose not to add this to any Bootc |
LGTM, but this should also be for bootc containers. It would only be used when they run as an OCI Container not when they are installed onto a full OS. |
49a71d3
to
eb0fed7
Compare
So if I am understanding this it should be baked into the bootc build commands but not whatever actually runs the bootc image? |
5e00f7b
to
e896899
Compare
@rhatdan I have included my attempt at the bootc changes, could you give it a once over whenever? I ended up including it in the |
e896899
to
f42a013
Compare
recipes/computer_vision/object_detection/model_server/Containerfile
Outdated
Show resolved
Hide resolved
recipes/computer_vision/object_detection/model_server/Containerfile
Outdated
Show resolved
Hide resolved
recipes/natural_language_processing/chatbot/bootc/Containerfile
Outdated
Show resolved
Hide resolved
recipes/natural_language_processing/chatbot/bootc/Containerfile.nocache
Outdated
Show resolved
Hide resolved
recipes/natural_language_processing/codegen/bootc/Containerfile
Outdated
Show resolved
Hide resolved
recipes/natural_language_processing/codegen/bootc/Containerfile.nocache
Outdated
Show resolved
Hide resolved
recipes/natural_language_processing/summarizer/bootc/Containerfile
Outdated
Show resolved
Hide resolved
recipes/natural_language_processing/summarizer/bootc/Containerfile.nocache
Outdated
Show resolved
Hide resolved
@MichaelClifford PTAL, are the exposed PORTS above static and defined in Code? |
6320fc1
to
4e615b3
Compare
Signed-off-by: greg pereira <[email protected]>
4e615b3
to
040b855
Compare
For the app's the port could change depending on the model server they are connecting to. Our llamacpp_python uses And all the Apps just use |
recipes/computer_vision/object_detection/model_server/Containerfile
Outdated
Show resolved
Hide resolved
…rfile Co-authored-by: Michael Clifford <[email protected]>
@@ -101,7 +102,7 @@ bootc: quadlet | |||
|
|||
.PHONY: bootc-run | |||
bootc-run: | |||
podman run -d --rm --name $(APP)-bootc -p 8080:8501 --privileged \ | |||
podman run -d --rm --name $(APP)-bootc -p 8080:$(PORT) --privileged \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be ${PORT}:80 or something like that.
Not sure this is going to end up working. I dusted it off and I am encountering an issue with all the recipe pieces where its very difficult to pass build time ARGs to runtime ARGs in |
I discovered when playing around with builds that the way we were passing
PORT
arguments wasnt working, because we both were exposing a static port number in theContainerfile
and because we were passing the actual argument for it incorrectly:Then verified inspecting the image:
The new builds produce the following: