Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests #254

Closed
wants to merge 1 commit into from
Closed

Integration tests #254

wants to merge 1 commit into from

Conversation

sallyom
Copy link
Collaborator

@sallyom sallyom commented Apr 12, 2024

Depends on #247
This adds integration tests & pushes/mirrors new images to quay.io/ai-lab
Resolves #205

Signed-off-by: sallyom <[email protected]>
@sallyom sallyom force-pushed the integration-tests branch from 5e9fcda to 294ef3d Compare April 14, 2024 00:28
@sallyom
Copy link
Collaborator Author

sallyom commented Apr 15, 2024

@Gregory-Pereira @lmilbaum this is failing with "out of VPCs" error, specific to AWS account - this adds make bootc test for various apps in the testing-framework workflow.

Error: creating EC2 VPC: operation error EC2: CreateVpc, https response error StatusCode: 400, api error VpcLimitExceeded: The maximum number of VPCs has been reached.

@MichaelClifford
Copy link
Collaborator

@sallyom is this PR still needed?

Copy link
Collaborator

@Gregory-Pereira Gregory-Pereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm, but 1 change

Comment on lines +148 to +149
#- image: llamacpp_python_vulkan
- image: llamacpp_python_cuda
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are labeled wrong, llamacpp_python is correct though:

Suggested change
#- image: llamacpp_python_vulkan
- image: llamacpp_python_cuda
#- image: llamacpp-python-vulkan
- image: llamacpp-python-cuda

@Gregory-Pereira
Copy link
Collaborator

@lmilbaum these are failing due to max VPCs in AWS it looks like. We would probably have to increase that if we want integration tests for all of our applications: VpcLimitExceeded: The maximum number of VPCs has been reached.. Also will we want to run these jobs on the containers-mirror/ai-lab-recipes or containers/ai-lab-recipes.

@lmilbaum
Copy link
Collaborator

lmilbaum commented May 2, 2024

@sallyom Should this contribution land in 1.1.0 release?

@Gregory-Pereira
Copy link
Collaborator

I don't know, I was never informed that this is required. That being said Sally has been working on this for a while, I say we defer to her judgement here. If she wants it we can work with here to see if we can get in.

@rhatdan
Copy link
Member

rhatdan commented May 2, 2024

I would say no, this should not block release.

@lmilbaum
Copy link
Collaborator

lmilbaum commented Jun 3, 2024

Is this PR still needed? It is stale for quite some time now.

@rhatdan
Copy link
Member

rhatdan commented Jun 3, 2024

I will close it, @sallyom can reopen it of create a new PR.

@rhatdan rhatdan closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need integration testing for all sample applications
5 participants