-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration tests #254
Integration tests #254
Conversation
23d42dd
to
5e9fcda
Compare
Signed-off-by: sallyom <[email protected]>
5e9fcda
to
294ef3d
Compare
@Gregory-Pereira @lmilbaum this is failing with "out of VPCs" error, specific to AWS account - this adds
|
@sallyom is this PR still needed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm, but 1 change
#- image: llamacpp_python_vulkan | ||
- image: llamacpp_python_cuda |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are labeled wrong, llamacpp_python
is correct though:
#- image: llamacpp_python_vulkan | |
- image: llamacpp_python_cuda | |
#- image: llamacpp-python-vulkan | |
- image: llamacpp-python-cuda |
@lmilbaum these are failing due to max VPCs in AWS it looks like. We would probably have to increase that if we want integration tests for all of our applications: |
@sallyom Should this contribution land in 1.1.0 release? |
I don't know, I was never informed that this is required. That being said Sally has been working on this for a while, I say we defer to her judgement here. If she wants it we can work with here to see if we can get in. |
I would say no, this should not block release. |
Is this PR still needed? It is stale for quite some time now. |
I will close it, @sallyom can reopen it of create a new PR. |
Depends on #247
This adds integration tests & pushes/mirrors new images to quay.io/ai-lab
Resolves #205