Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build cuda image #246

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Build cuda image #246

merged 1 commit into from
Apr 15, 2024

Conversation

lmilbaum
Copy link
Collaborator

@lmilbaum lmilbaum commented Apr 11, 2024

I've rebased this PR with the latest changes. I'm not 100% sure the rebase is good. Please take a deep look before approving.

@lmilbaum lmilbaum self-assigned this Apr 11, 2024
@lmilbaum lmilbaum force-pushed the cuda branch 9 times, most recently from 417e672 to e5fb781 Compare April 11, 2024 15:18
@sallyom
Copy link
Collaborator

sallyom commented Apr 11, 2024

with this PR I'm also setting up the other model-servers!

@lmilbaum lmilbaum force-pushed the cuda branch 7 times, most recently from 0246e71 to 0598e6d Compare April 15, 2024 09:34
Signed-off-by: Liora Milbaum <[email protected]>
@lmilbaum lmilbaum marked this pull request as ready for review April 15, 2024 12:19
Copy link
Collaborator

@Gregory-Pereira Gregory-Pereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
We should make those cuda tests at some point, ill try to look into it

@rhatdan rhatdan merged commit bf08058 into main Apr 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants