Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable linter on windows #4

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

akhilerm
Copy link
Member

  • add windows-2022 runner for linting
  • set line endings while checking out via .gitattributes to fix lint issues in windows

Signed-off-by: Akhil Mohan <[email protected]>
@@ -0,0 +1 @@
*.go text eol=lf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing end of line after setting eol to line feed :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No biggie 😆

@dmcgowan dmcgowan merged commit d9a63aa into containerd:main Jan 19, 2024
7 checks passed
@akhilerm akhilerm deleted the fix-windows-linter branch January 20, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants