Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Eth legacy transactions #927

Closed
maciejwitowski opened this issue May 13, 2024 · 1 comment · Fixed by #1235
Closed

Support Eth legacy transactions #927

maciejwitowski opened this issue May 13, 2024 · 1 comment · Fixed by #1235
Assignees
@cryptoAtwill
Labels
epic feature New feature or request

Comments

@maciejwitowski
Copy link
Contributor

No description provided.

@maciejwitowski maciejwitowski added the feature New feature or request label May 13, 2024
@raulk raulk changed the title Eth legacy transactions Support Eth legacy transactions May 16, 2024
@raulk
Copy link
Contributor

raulk commented Dec 10, 2024

We only support legacy transactions partially for estimation purposes:

ipc/fendermint/eth/api/src/conv/from_eth.rs

Line 20 in ebb743f

// legacy transactions are only accepted for gas estimation purposes

This is how Filecoin bolted on Eth legacy tx support recently:

https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0091.md

This is needed to deploy things like Gnosis Safe on IPC subnets; unfortunately legacy transactions are quite ossified in some libraries / tools.

@raulk raulk linked a pull request Dec 18, 2024 that will close this issue
feat(node): support legacy transactions #1235
Merged
@raulk raulk mentioned this issue Dec 18, 2024
Merged
@github-project-automation github-project-automation bot moved this from Backlog to Done in IPC Core Development Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cryptoAtwill cryptoAtwill

Labels
epic feature New feature or request
Projects
IPC Core Development
Archived in project
[WIP] IPC Feature Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(node): support legacy transactions consensus-shipyard/ipc
3 participants
@raulk @maciejwitowski @cryptoAtwill