Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export an interface-only module so it's easier to dev with #3457

Closed
ArjunBhuptani opened this issue Feb 9, 2023 · 4 comments
Closed

Export an interface-only module so it's easier to dev with #3457

ArjunBhuptani opened this issue Feb 9, 2023 · 4 comments
Assignees
Labels
Enhance 🧘 Issue type: Enhancement Request integrations

Comments

@ArjunBhuptani
Copy link
Member

When importing Connext modules, you are forced to import 60+ contracts. We should create a repo to export only the core contracts needed for integration

@alexwhte alexwhte added the Enhance 🧘 Issue type: Enhancement Request label Feb 13, 2023
@just-a-node
Copy link
Collaborator

just-a-node commented Feb 16, 2023

Proposal

Create a separate repo as connext/interfaces which will be the main repo to install with Forge and npm

  • copy subset of contract interfaces relevant for integrators (IConnext.sol, IXReceiver.sol, any others? that might be it)
  • create abstract contract implementing IXReceiver that includes onlySource authentication modifier
  • [later] create abstract contract implementing IXReceiver that includes rescue/orphan functionality
  • set up CI to publish npm package

@rhlsthrm
Copy link
Collaborator

This sounds good to me!

@ArjunBhuptani
Copy link
Member Author

Looks good, should also potentially include a Mock.sol (talk to Derby Finance team as they have already written this)

@just-a-node
Copy link
Collaborator

Closing this out as @connext/interfaces v1.0.0 is set up now.

Extracting abstract patterns into #3638 and mocks into #3640.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhance 🧘 Issue type: Enhancement Request integrations
Projects
None yet
Development

No branches or pull requests

4 participants