Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace use of sed for yaml templating with Yaml.sh or helm charts #113

Open
diverdane opened this issue Oct 19, 2020 · 0 comments
Open

Comments

@diverdane
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Several of the scripts in this repo make use of sed to replace templated fields
in YAML files. For example, here's an example field replacement using sed:

```
sed "s#{{ CONJUR_ACCOUNT }}#$CONJUR_ACCOUNT#g"
```

The scripts that use sed for this purpose include:

  • 2_admin_load_conjur_policies.sh
  • 4_app_create_namespace.sh
  • 6_app_build_and_push_containers.sh
  • 7_app_deploy.sh

This templating solution is difficult to follow and maintain. It would be better to
replace these uses of sed with either:

Note: this suggestion came up during review for PR #107.

Describe the solution you would like

Helm charts are used wherever possible. Or, for cases such as policy templating, use Yaml.sh.

Describe alternatives you have considered

Additional context

This suggestion came up during review for PR #107.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant