Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the CLI to use a presentation layer #95

Open
carltonwhitehead opened this issue Jun 30, 2023 · 2 comments
Open

Refactor the CLI to use a presentation layer #95

carltonwhitehead opened this issue Jun 30, 2023 · 2 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@carltonwhitehead
Copy link
Contributor

carltonwhitehead commented Jun 30, 2023

The CLI is meant to be a thin wrapper around the rest of the project. It currently has way too many non-reusable presentation concerns factored into it.

Refactor as many of them as possible to interact only with a presenter, model, and view instances. They generally should not interact with services directly.

The presenters are to use flows to support modern reactive UIs.

@carltonwhitehead
Copy link
Contributor Author

The render and render-text modules are becoming really Presentation layer concerned. Time for a rename.

The PropertyRenderer and ViewRenderer can be renamed for simplicity to Adapter and View, respectively.

@carltonwhitehead carltonwhitehead changed the title Consolidate the CLI view package into the render-text package Refactor the CLI to use a presentation layer Aug 4, 2023
@carltonwhitehead carltonwhitehead moved this to In Progress in Admin CLI app Nov 27, 2023
@carltonwhitehead
Copy link
Contributor Author

The surface area of this work is huge. It affects practically every command already written. That's going to be a lot of repetitive, boring work to do, hard to gauge what is needed for other UIs, creating uncertainty around the goalposts for this ticket. This project is supposed to be fun to work on, not a soul-suck. Therefore I'm not going to do this all at once. Instead, I will do these one-by-one as opportunities for code reuse arise when developing UIs.

If anyone wants to dip a toe into this project and help out in a meaningful way, add a comment here and/or reach me through another channel, and I'll be happy to go over the steps to do a small chunk of this.

@carltonwhitehead carltonwhitehead added help wanted Extra attention is needed good first issue Good for newcomers labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: In Progress
Development

No branches or pull requests

1 participant