Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package the IDAKLU solver in the recipe #65

Open
agriyakhetarpal opened this issue Nov 15, 2024 · 4 comments
Open

Package the IDAKLU solver in the recipe #65

agriyakhetarpal opened this issue Nov 15, 2024 · 4 comments

Comments

@agriyakhetarpal
Copy link
Member

This is a medium-term issue that we should start considering to do since PyBaMM will migrate to using the IDAKLU solver as the default instead of the CasadiSolver.

This requires fixing the sdist, compiling SuiteSparse, and compiling SUNDIALS with KLU linked from SuiteSparse. We might need to patch PyBaMM to not use the CasADi Python package and compile the C interface ourselves (with minimal interfaces), and later turn binary relocation on for the feedstock. We could also introduce additional extension modules for this task.

We can then remove it and package pybammsolvers as a separate conda-forge feedstock to use here as a dependency once i. pybamm-team/PyBaMM#4487 is done and ii. things are stable enough for at least one release after the transition

@agriyakhetarpal
Copy link
Member Author

This is where I begin to feel that migrating to Meson instead of scikit-build-core might have been better – no one wants to deal with CMake 😃

@martinjrobins
Copy link

This is where I begin to feel that migrating to Meson instead of scikit-build-core might have been better – no one wants to deal with CMake 😃

But I've already spent too much of my life fighting with CMake and learning its weird eccentricities!

@agriyakhetarpal
Copy link
Member Author

Hi @prady0t, how is this going – do you need any help somewhere? Please let us know if you do!

@prady0t
Copy link

prady0t commented Dec 9, 2024

Hi @prady0t, how is this going – do you need any help somewhere? Please let us know if you do!

Few exam days before I can get back to this 🤒

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants