-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package the IDAKLU solver in the recipe #65
Comments
This is where I begin to feel that migrating to Meson instead of scikit-build-core might have been better – no one wants to deal with CMake 😃 |
But I've already spent too much of my life fighting with CMake and learning its weird eccentricities! |
Hi @prady0t, how is this going – do you need any help somewhere? Please let us know if you do! |
Few exam days before I can get back to this 🤒 |
This is a medium-term issue that we should start considering to do since PyBaMM will migrate to using the IDAKLU solver as the default instead of the CasadiSolver.
This requires fixing the sdist, compiling SuiteSparse, and compiling SUNDIALS with KLU linked from SuiteSparse. We might need to patch PyBaMM to not use the CasADi Python package and compile the C interface ourselves (with minimal interfaces), and later turn binary relocation on for the feedstock. We could also introduce additional extension modules for this task.
We can then remove it and package
pybammsolvers
as a separate conda-forge feedstock to use here as a dependency once i. pybamm-team/PyBaMM#4487 is done and ii. things are stable enough for at least one release after the transitionThe text was updated successfully, but these errors were encountered: