-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ABI break between clang 17 & 18 causing linkage errors with abseil #87
Comments
Ah well... conda-forge/libprotobuf-feedstock#244 was applied to 5.28.3, but our pinning is on 5.28.2 😑 However, at least that means we can just migrate for 5.28.3 to ensure stuff gets built consistently |
After #86 I think I am starting observing in downstream CI the opposite problem in downstream builds of jax.
see ami-iit/adam#115 for more details. Just a bit of recap, from what I understand the situation is the following:
The problem is that the latest build of |
I found a similar issue but with libgpr:
|
I opened conda-forge/jaxlib-feedstock#296 for visibility. |
It would be nice if we could patch abseil to contain both symbols. |
Unfortunately, importing pytorch with this version of libabseil is also failing with the same issues reported here. |
Just in case it is not clear, temporary pinning libabseil to the version |
Right! I just came to report a similar fix with |
For pytorch this breaks all current and historical packages due to the hard patch-level pin on libprotobuf:
I'm not sure where the best place is to help this situation |
Thanks a lot for working on this @isuruf ! |
Nice work on this, I can confirm this fixes my local testings on osx-arm64 when importing pytorch with fresh environment (via pixi) 🚀 |
The change from clang 17 to clang 18 seems to have cause an ABI break w.r.t. symbol mangling, causing failures of the following kind when different builds are mixed
To fix this, I had added #86, but this has just moved the problem further down the stack. We've rebuilt
so far, but it appears from post-merge comments in #86 that also other places like arrow are affected.
The text was updated successfully, but these errors were encountered: