Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a PHP coding style checker/fixer command #9

Open
mlocati opened this issue Sep 23, 2021 · 4 comments
Open

Add a PHP coding style checker/fixer command #9

mlocati opened this issue Sep 23, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@mlocati
Copy link
Contributor

mlocati commented Sep 23, 2021

Referring to concretecms/concretecms#9852 (comment): what about moving the c5:phpcs CLI command (and all the related code) from the core to this project?

@KorvinSzanto
Copy link
Member

Is this command something that people would use outside of core development?

@aembler
Copy link
Member

aembler commented Sep 23, 2021

I would expect this to be valuable for anyone developing Concrete code, whether it's for the core or for their own custom site/package

@mlocati
Copy link
Contributor Author

mlocati commented Sep 23, 2021

Yep, it's for developers only.
Having a coding style checker/fixer in the core or in this CLI tool would both work for me, but I'd prefer this CLI tool because:

  • it can be updated more frequently than the core
  • we don't have in the core some code that's only used by a 0.1% of users

@KorvinSzanto
Copy link
Member

Fair enough, makes sense to me as long as it's useful outside of core development 👍

@KorvinSzanto KorvinSzanto added the enhancement New feature or request label Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants