Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly calculate the relative containing block for grid flow elements #6712

Closed
ruggi opened this issue Dec 9, 2024 · 0 comments · Fixed by #6713
Closed

Correctly calculate the relative containing block for grid flow elements #6712

ruggi opened this issue Dec 9, 2024 · 0 comments · Fixed by #6713
Assignees
@ruggi

Comments

@ruggi
Copy link
Contributor

ruggi commented Dec 9, 2024

No description provided.

@ruggi ruggi self-assigned this Dec 9, 2024
@ruggi ruggi mentioned this issue Dec 9, 2024
Merged
2 tasks
@ruggi ruggi closed this as completed in 544461a Dec 10, 2024
liady pushed a commit that referenced this issue Dec 13, 2024
@ruggi @liady
Fix getGridRelativeContainingBlock for flow elements (#6713)
8859734 
**Problem:**

`getGridRelativeContainingBlock` doesn't correctly return the item
position for flow elements. It was temporarily patched with the
positioning coming from `getGridChildCellCoordBoundsFromCanvas`, but
this PR instead fixes it for good, which cascade-solves a bunch of other
small bugs.

**Fix:**

The flow positioning requires _all_ preceding grid items to be available
in the grid, so this PR does just that: inject every (ordered!) child
into the temporary grid, retrieve the wanted one, and return its
bounding box.

**Manual Tests:**
I hereby swear that:

- [x] I opened a hydrogen project and it loaded
- [x] I could navigate to various routes in Play mode

Fixes #6712
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruggi ruggi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix getGridRelativeContainingBlock for flow elements concrete-utopia/utopia
1 participant
@ruggi