Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve alignSelf/justifySelf when resizing a fixed grid item #6710

Closed
ruggi opened this issue Dec 9, 2024 · 0 comments · Fixed by #6711
Closed

preserve alignSelf/justifySelf when resizing a fixed grid item #6710

ruggi opened this issue Dec 9, 2024 · 0 comments · Fixed by #6711
Assignees

Comments

@ruggi
Copy link
Contributor

ruggi commented Dec 9, 2024

No description provided.

@ruggi ruggi self-assigned this Dec 9, 2024
@ruggi ruggi closed this as completed in 6f5cb65 Dec 9, 2024
liady pushed a commit that referenced this issue Dec 13, 2024
…6711)

**Problem:**

When resizing a grid item with fixed sizes, it loses any `alignSelf` or
`justifySelf` props that were defined on it.

**Fix:**

Make sure to not nuke those props when resizing grid items.

**Manual Tests:**
I hereby swear that:

- [x] I opened a hydrogen project and it loaded
- [x] I could navigate to various routes in Play mode

Fixes #6710
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant