Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust ruler marker resize for spanning items #6701

Closed
ruggi opened this issue Dec 5, 2024 · 0 comments · Fixed by #6703
Closed

adjust ruler marker resize for spanning items #6701

ruggi opened this issue Dec 5, 2024 · 0 comments · Fixed by #6703
Assignees
@ruggi

Comments

@ruggi
Copy link
Contributor

ruggi commented Dec 5, 2024

No description provided.

@ruggi ruggi self-assigned this Dec 5, 2024
@ruggi ruggi mentioned this issue Dec 5, 2024
Merged
2 tasks
@ruggi ruggi closed this as completed in 1aa3387 Dec 5, 2024
liady pushed a commit that referenced this issue Dec 13, 2024
@ruggi @liady
Adjust ruler marker resize for spanning elements (#6703)
2a3053d 
**Problem:**

Ruler marker resize needs some extra tweaks for spanning elements.

**Fix:**

1. Make it possible to resize correctly a flow item that spans from the
start by dragging its end marker
2. Make it possible to resize correctly a flow item that spans from the
end by dragging its start/end markers and treat them as a more
traditional shrink/expand

Also added specific tests for span combinations.

**Manual Tests:**
I hereby swear that:

- [x] I opened a hydrogen project and it loaded
- [x] I could navigate to various routes in Play mode

Fixes #6701
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruggi ruggi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adjust ruler marker resize for spanning elements concrete-utopia/utopia
1 participant
@ruggi