Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grid offset lines #6675

Closed
ruggi opened this issue Nov 22, 2024 · 0 comments · Fixed by #6674
Closed

grid offset lines #6675

ruggi opened this issue Nov 22, 2024 · 0 comments · Fixed by #6674
Assignees

Comments

@ruggi
Copy link
Contributor

ruggi commented Nov 22, 2024

No description provided.

@ruggi ruggi self-assigned this Nov 22, 2024
@ruggi ruggi mentioned this issue Nov 22, 2024
2 tasks
ruggi added a commit that referenced this issue Nov 22, 2024
**Problem:**

When a grid item is selected, there should be outline lines around the
cell bounds, which also expand to meet the ruler markers.

**Fix:**

Implement one component to render the cell bounds outline, and one
component for the lines stretching to the markers from the cell
perimeter.

<img width="807" alt="Screenshot 2024-11-22 at 11 59 11"
src="https://github.com/user-attachments/assets/e82672bc-f7dd-4dd2-9b24-6f2c6d286feb">


https://github.com/user-attachments/assets/9a69b131-a052-42ab-88c6-f1534c3865af

**Manual Tests:**
I hereby swear that:

- [x] I opened a hydrogen project and it loaded
- [x] I could navigate to various routes in Play mode

Fixes #6675
liady pushed a commit that referenced this issue Dec 13, 2024
**Problem:**

When a grid item is selected, there should be outline lines around the
cell bounds, which also expand to meet the ruler markers.

**Fix:**

Implement one component to render the cell bounds outline, and one
component for the lines stretching to the markers from the cell
perimeter.

<img width="807" alt="Screenshot 2024-11-22 at 11 59 11"
src="https://github.com/user-attachments/assets/e82672bc-f7dd-4dd2-9b24-6f2c6d286feb">


https://github.com/user-attachments/assets/9a69b131-a052-42ab-88c6-f1534c3865af

**Manual Tests:**
I hereby swear that:

- [x] I opened a hydrogen project and it loaded
- [x] I could navigate to various routes in Play mode

Fixes #6675
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant