Preserve span when reordering #6641
Assignees
Comments
ruggi
added a commit
that referenced
this issue
Nov 14, 2024
**Problem:** Spans (or otherwise 1+ sized elements) are not preserved when using `gridReorderStrategy`. **Fix:** When running the reorder strategy, instead of nuking all positioning props only nuke the ones which are not used and, for elements that occupy multiple cells, set the respective width or height using the `span` syntax on the correct shorthand. I also took this chance to move the reorder tests to their own file (and added the new tests there). Fixes #6641
seanparsons
pushed a commit
that referenced
this issue
Nov 18, 2024
**Problem:** Spans (or otherwise 1+ sized elements) are not preserved when using `gridReorderStrategy`. **Fix:** When running the reorder strategy, instead of nuking all positioning props only nuke the ones which are not used and, for elements that occupy multiple cells, set the respective width or height using the `span` syntax on the correct shorthand. I also took this chance to move the reorder tests to their own file (and added the new tests there). Fixes #6641
liady
pushed a commit
that referenced
this issue
Dec 13, 2024
**Problem:** Spans (or otherwise 1+ sized elements) are not preserved when using `gridReorderStrategy`. **Fix:** When running the reorder strategy, instead of nuking all positioning props only nuke the ones which are not used and, for elements that occupy multiple cells, set the respective width or height using the `span` syntax on the correct shorthand. I also took this chance to move the reorder tests to their own file (and added the new tests there). Fixes #6641
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: