Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting a file with a syntax error leaves the canvas permanently broken #6300

Closed
Rheeseyb opened this issue Sep 3, 2024 · 0 comments · Fixed by #6309
Closed

Deleting a file with a syntax error leaves the canvas permanently broken #6300

Rheeseyb opened this issue Sep 3, 2024 · 0 comments · Fixed by #6309
Assignees
@liady
Labels
Code / Parsing Something related to our reading or writing of code

Comments

@Rheeseyb
Copy link
Contributor

Rheeseyb commented Sep 3, 2024 •
edited
Loading

We should clear errors and re-evaluate the project when a file is deleted
@maltenuhn maltenuhn added the Code / Parsing Something related to our reading or writing of code label Sep 3, 2024
@liady liady mentioned this issue Sep 4, 2024
Merged
2 tasks
@liady liady self-assigned this Sep 4, 2024
@liady liady closed this as completed in e7cc599 Sep 4, 2024
liady added a commit that referenced this issue Dec 13, 2024
@liady
fix(editor): remove error messages when deleting a file (#6309)
cda1acd 
**Problem:**
We currently clear errors only when a descriptor file is deleted. This
can cause syntax errors to remain even after the file that they're in
was deleted.

**Fix:**
Clear errors on every file delete

**Manual Tests:**
I hereby swear that:

- [X] I opened a hydrogen project and it loaded
- [X] I could navigate to various routes in Preview mode

Fixes #6300
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liady liady

Labels
Code / Parsing Something related to our reading or writing of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(editor): remove error messages when deleting a file concrete-utopia/utopia
3 participants
@Rheeseyb @maltenuhn @liady