Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support grid autoRows/autoCols values in the inspector #6288

Closed
ruggi opened this issue Sep 2, 2024 · 0 comments · Fixed by #6289
Closed

support grid autoRows/autoCols values in the inspector #6288

ruggi opened this issue Sep 2, 2024 · 0 comments · Fixed by #6289
Assignees
@ruggi

Comments

@ruggi
Copy link
Contributor

ruggi commented Sep 2, 2024

No description provided.

@ruggi ruggi self-assigned this Sep 2, 2024
@ruggi ruggi mentioned this issue Sep 2, 2024
Merged
ruggi added a commit that referenced this issue Sep 3, 2024
@ruggi
Parse and display auto values in the inspector (#6289)
b8c196a 
**Problem:**

Values coming from `gridAutoRows` and `gridAutoColumns` are not shown in
the inspector's grid template.

**Fix:**

Include those values in the calculations for the displayed values in the
grid inputs.
Contextually added full tests coverage for the existing and expanded
logic in `mergeGridTemplateValues`.

Fixes #6288
liady pushed a commit that referenced this issue Dec 13, 2024
@ruggi @liady
Parse and display auto values in the inspector (#6289)
d42b010 
**Problem:**

Values coming from `gridAutoRows` and `gridAutoColumns` are not shown in
the inspector's grid template.

**Fix:**

Include those values in the calculations for the displayed values in the
grid inputs.
Contextually added full tests coverage for the existing and expanded
logic in `mergeGridTemplateValues`.

Fixes #6288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruggi ruggi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Parse and display auto values in the inspector concrete-utopia/utopia
1 participant
@ruggi