Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freeze grid template during cell move #6200

Closed
ruggi opened this issue Aug 7, 2024 · 0 comments · Fixed by #6201
Closed

freeze grid template during cell move #6200

ruggi opened this issue Aug 7, 2024 · 0 comments · Fixed by #6201
Assignees
@ruggi

Comments

@ruggi
Copy link
Contributor

ruggi commented Aug 7, 2024

No description provided.

@ruggi ruggi self-assigned this Aug 7, 2024
@ruggi ruggi mentioned this issue Aug 7, 2024
Merged
ruggi added a commit that referenced this issue Aug 7, 2024
@ruggi
Freeze grid template during child move (#6201)
846c1ff 
**Problem:**

Moving grid elements if the template is somewhat dynamic will result in
the grid elements likely jumping around because their template changes
constantly.

**Fix:**

Freeze the template during the interaction, by using the calculated
dimensions, and restore it once the interaction completes.

In the example below, one column is made `min-content` with some
fixed-sized elements inside.

| Before | After |
|-------|-------------|
| ![Kapture 2024-08-07 at 15 37
27](https://github.com/user-attachments/assets/da2d824a-ad02-494a-8ff6-7cc03e3b5c95)
| ![Kapture 2024-08-07 at 15 36
21](https://github.com/user-attachments/assets/283a5fc0-69b9-41e3-85d2-51be14279585)
|

Fixes #6200
liady pushed a commit that referenced this issue Dec 13, 2024
@ruggi @liady
Freeze grid template during child move (#6201)
3391b94 
**Problem:**

Moving grid elements if the template is somewhat dynamic will result in
the grid elements likely jumping around because their template changes
constantly.

**Fix:**

Freeze the template during the interaction, by using the calculated
dimensions, and restore it once the interaction completes.

In the example below, one column is made `min-content` with some
fixed-sized elements inside.

| Before | After |
|-------|-------------|
| ![Kapture 2024-08-07 at 15 37
27](https://github.com/user-attachments/assets/da2d824a-ad02-494a-8ff6-7cc03e3b5c95)
| ![Kapture 2024-08-07 at 15 36
21](https://github.com/user-attachments/assets/283a5fc0-69b9-41e3-85d2-51be14279585)
|

Fixes #6200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruggi ruggi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Freeze grid template during child move concrete-utopia/utopia
1 participant
@ruggi