Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if an error is thrown by a loader(), we only log it to the console, but silently let the canvas run forward, which may lead to other runtime errors that are misleading #6185

Open
balazsbajorics opened this issue Aug 6, 2024 · 1 comment
Labels
Bug Something isn't working

Comments

@balazsbajorics
Copy link
Contributor

balazsbajorics commented Aug 6, 2024

steps to reproduce: open the hydrogen test project, put a throw new Error('hello') in any of the loaders, and witness as the error is logged to the console, but the canvas is still rendering.

fix: the error message should show up as a big red canvas runtime error, with our usual source code snippet handling etc

@balazsbajorics balazsbajorics added the Bug Something isn't working label Aug 6, 2024
@liady liady self-assigned this Aug 8, 2024
@seanparsons seanparsons self-assigned this Oct 1, 2024
@seanparsons
Copy link
Contributor

@balazsbajorics I added one of these to a loader and it worked fine:
image

Maybe it only breaks for a certain kind?

@seanparsons seanparsons removed their assignment Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants