Duplicate cursor when alt is pressed #6115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#13493 Bundle Size — 62.61MiB (~+0.01%).
Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #13493 |
Baseline #13490 |
|
|---|---|---|
 Initial JS |
45.68MiB(~+0.01%) |
45.68MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
21.52% |
21.5% |
| Chunks |
31 |
31 |
| Assets |
34 |
34 |
| Modules |
4376 |
4376 |
| Duplicate Modules |
523 |
523 |
| Duplicate Code |
31.65% |
31.65% |
| Packages |
469 |
469 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #13493 |
Baseline #13490 |
|
|---|---|---|
| JS |
62.6MiB (~+0.01%) |
62.6MiB |
| HTML |
11.16KiB (-0.33%) |
11.2KiB |
Bundle analysis report Branch fix/duplicate-cursor Project dashboard
bkrmendy
approved these changes
Jul 24, 2024
ruggi
approved these changes
Jul 24, 2024
2 tasks
gbalint
added a commit
that referenced
this pull request
Jul 25, 2024
**Problem:** In #6115 I did not put the logic into the proper, already existing function, and I caused a regression (duplicate cursor was shown when alt-z was pressed) **Fix:** Revert my original solution and put the logic into the existing `cursorForKeysPressed` function. Add new tests to make sure this regression does not happen again. **Manual Tests:** I hereby swear that: - [x] I opened a hydrogen project and it loaded - [x] I could navigate to various routes in Preview mode
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** We should show the duplicate mouse cursor when alt is pressed, even before the interaction starts (so the user knows what is going to happen). **Fix:** Set the canvas control cursor to the duplicate cursor when alt is pressed. **Manual Tests:** I hereby swear that: - [x] I opened a hydrogen project and it loaded - [x] I could navigate to various routes in Preview mode Fixes #6083
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** In #6115 I did not put the logic into the proper, already existing function, and I caused a regression (duplicate cursor was shown when alt-z was pressed) **Fix:** Revert my original solution and put the logic into the existing `cursorForKeysPressed` function. Add new tests to make sure this regression does not happen again. **Manual Tests:** I hereby swear that: - [x] I opened a hydrogen project and it loaded - [x] I could navigate to various routes in Preview mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
We should show the duplicate mouse cursor when alt is pressed, even before the interaction starts (so the user knows what is going to happen).
Fix:
Set the canvas control cursor to the duplicate cursor when alt is pressed.
Manual Tests:
I hereby swear that:
Fixes #6083