Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload Grid Icons #6109

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Upload Grid Icons #6109

merged 1 commit into from
Jul 22, 2024

Conversation

lankaukk
Copy link
Collaborator

Uploading new icons to be used in the new grid sections of the inspector

Screenshot 2024-07-22 at 5 27 49 PM

Copy link
Contributor

github-actions bot commented Jul 22, 2024

Try me

Copy link

relativeci bot commented Jul 22, 2024

#13469 Bundle Size — 62.64MiB (~-0.01%).

958cff5(current) vs 6339ece master#13455(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#13469
     Baseline
#13455
Regression  Initial JS 45.71MiB(~+0.01%) 45.71MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 21.56% 22.28%
No change  Chunks 31 31
No change  Assets 34 34
No change  Modules 4377 4377
No change  Duplicate Modules 525 525
No change  Duplicate Code 31.69% 31.69%
No change  Packages 469 469
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#13469
     Baseline
#13455
Regression  JS 62.63MiB (~+0.01%) 62.63MiB
Improvement  HTML 11.16KiB (-0.33%) 11.2KiB

Bundle analysis reportBranch grid-iconsProject dashboard

@lankaukk lankaukk merged commit 7e555e9 into master Jul 22, 2024
14 checks passed
@lankaukk lankaukk deleted the grid-icons branch July 22, 2024 21:53
ruggi added a commit that referenced this pull request Jul 30, 2024
**Problem:**

The inspector's grid placement subsection controls should use the new
icons from #6109.

**Fix:**

1. Use the new icons
2. Adjust the labels

![Kapture 2024-07-30 at 10 24
55](https://github.com/user-attachments/assets/d4074e0a-9f4f-428a-bca7-5c1597c3d1cd)


Fixes #6141
liady pushed a commit that referenced this pull request Dec 13, 2024
Uploading new icons to be used in the new grid sections of the inspector

<img width="642" alt="Screenshot 2024-07-22 at 5 27 49 PM"
src="https://github.com/user-attachments/assets/81aca089-d737-40bf-bd3c-07a32fa8e31d">
liady pushed a commit that referenced this pull request Dec 13, 2024
**Problem:**

The inspector's grid placement subsection controls should use the new
icons from #6109.

**Fix:**

1. Use the new icons
2. Adjust the labels

![Kapture 2024-07-30 at 10 24
55](https://github.com/user-attachments/assets/d4074e0a-9f4f-428a-bca7-5c1597c3d1cd)


Fixes #6141
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant