Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canvas Performance: getRemixExportsOfModule calls createExecutionScope a lot #6064

Closed
balazsbajorics opened this issue Jul 11, 2024 · 0 comments · Fixed by #6076
Closed

Canvas Performance: getRemixExportsOfModule calls createExecutionScope a lot #6064

balazsbajorics opened this issue Jul 11, 2024 · 0 comments · Fixed by #6076
Assignees
@seanparsons
Labels
Canvas Affects the visual editor Nontrivial Requires invention / discovery to solve Performance

Comments

@balazsbajorics
Copy link
Contributor

Image

Looking at the Canvas render graph of resizing a PromiseCard:

Image

7-8ms is spent inside the UtopiaRemixRootComponent, most of it seems to be multiple repeated calls to createExecutionScope !!

None of that code should run during a canvas interaction. Ideally none of that code should run when the user did not navigate or changed the routes available.
@balazsbajorics balazsbajorics added Canvas Affects the visual editor Performance Nontrivial Requires invention / discovery to solve labels Jul 11, 2024
@seanparsons seanparsons self-assigned this Jul 12, 2024
@seanparsons seanparsons mentioned this issue Jul 12, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seanparsons seanparsons

Labels
Canvas Affects the visual editor Nontrivial Requires invention / discovery to solve Performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cache Execution Scope concrete-utopia/utopia
2 participants
@seanparsons @balazsbajorics