Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate keys on grid resize components #6056

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Fix duplicate keys on grid resize components #6056

merged 1 commit into from
Jul 10, 2024

Conversation

ruggi
Copy link
Contributor

@ruggi ruggi commented Jul 10, 2024

Problem:

Grid resize components don't have key props.

Fix:

Add them.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 10, 2024 •
edited
Loading

Try me

@relativeci RelativeCI
Copy link

relativeci bot commented Jul 10, 2024

#13305 Bundle Size — 62.62MiB (~+0.01%).

dfc1d0b(current) vs 6339ece master#13302(baseline)

Warning

Bundle contains 51 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#13305		      Baseline
#13302
Regression  Initial JS 45.67MiB(~+0.01%) 45.67MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 21.62% 21.58%
No change  Chunks 30 30
No change  Assets 33 33
No change  Modules 4350 4350
No change  Duplicate Modules 524 524
No change  Duplicate Code 31.71% 31.71%
No change  Packages 450 450
No change  Duplicate Packages 51 51
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#13305		      Baseline
#13302
Regression  JS 62.61MiB (~+0.01%) 62.61MiB
Improvement  HTML 11.16KiB (-0.33%) 11.2KiB

Bundle analysis report Branch fix/grid-resize-keys Project dashboard

@ruggi ruggi merged commit b17a40e into master Jul 10, 2024
17 checks passed
@ruggi ruggi deleted the fix/grid-resize-keys branch July 10, 2024 14:56
liady pushed a commit that referenced this pull request Dec 13, 2024
@ruggi @liady
Fix duplicate keys on grid resize components (#6056)
e3f4e9d 
**Problem:**

Grid resize components don't have `key` props.

**Fix:**

Add them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkrmendy bkrmendy bkrmendy approved these changes

@balazsbajorics balazsbajorics balazsbajorics approved these changes

@gbalint gbalint gbalint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ruggi @gbalint @balazsbajorics @bkrmendy