Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/zoom in grid move #6052

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Fix/zoom in grid move #6052

merged 2 commits into from
Jul 10, 2024

Conversation

ruggi
Copy link
Contributor

@ruggi ruggi commented Jul 9, 2024

Problem:

Moving grid cells (incl. drag-duplicating them) doesn't work with zoom > 1.

Fix:

Accommodate for the canvas scale when detecting target cells in the strategy helper.

Fixes #6051

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

Try me

@relativeci RelativeCI
Copy link

relativeci bot commented Jul 9, 2024

#13298 Bundle Size — 62.6MiB (~+0.01%).

e0ab73f(current) vs 6339ece master#13297(baseline)

Warning

Bundle contains 51 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#13298		      Baseline
#13297
Regression  Initial JS 45.66MiB(~+0.01%) 45.66MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 21.6% 23.85%
No change  Chunks 30 30
No change  Assets 33 33
No change  Modules 4349 4349
No change  Duplicate Modules 524 524
No change  Duplicate Code 31.72% 31.72%
No change  Packages 450 450
No change  Duplicate Packages 51 51
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#13298		      Baseline
#13297
Regression  JS 62.59MiB (~+0.01%) 62.59MiB
Improvement  HTML 11.16KiB (-0.33%) 11.2KiB

Bundle analysis report Branch fix/zoom-in-grid-move Project dashboard

@ruggi ruggi merged commit b1e856e into master Jul 10, 2024
16 checks passed
@ruggi ruggi deleted the fix/zoom-in-grid-move branch July 10, 2024 08:33
liady pushed a commit that referenced this pull request Dec 13, 2024
@ruggi @liady
Fix/zoom in grid move (#6052)
7150987 
**Problem:**

Moving grid cells (incl. drag-duplicating them) doesn't work with zoom >
1.

**Fix:**

Accommodate for the canvas scale when detecting target cells in the
strategy helper.

Fixes #6051
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liady liady liady approved these changes

@balazsbajorics balazsbajorics balazsbajorics approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Grid move doesn't work with zoom in
3 participants
@ruggi @balazsbajorics @liady