-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to select mode after opening pane #6048
Merged
bkrmendy
merged 2 commits into
master
from
fix/temp-switch-editor-mode-after-pane-select
Jul 9, 2024
Merged
Switch to select mode after opening pane #6048
bkrmendy
merged 2 commits into
master
from
fix/temp-switch-editor-mode-after-pane-select
Jul 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanparsons
approved these changes
Jul 9, 2024
liady
approved these changes
Jul 9, 2024
balazsbajorics
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is still horrible
#13291 Bundle Size — 62.51MiB (~+0.01%).
Warning Bundle contains 51 duplicate packages – View duplicate packages Bundle metrics
|
Current #13291 |
Baseline #13283 |
|
---|---|---|
Initial JS | 45.57MiB (~+0.01% ) |
45.57MiB |
Initial CSS | 0B |
0B |
Cache Invalidation | 21.62% |
0% |
Chunks | 30 |
30 |
Assets | 33 |
33 |
Modules | 4323 |
4323 |
Duplicate Modules | 524 |
524 |
Duplicate Code | 31.74% |
31.74% |
Packages | 450 |
450 |
Duplicate Packages | 51 |
51 |
Bundle size by type 2 changes
1 regression
1 improvement
Current #13291 |
Baseline #13283 |
|
---|---|---|
JS | 62.5MiB (~+0.01% ) |
62.5MiB |
HTML | 11.16KiB (-0.33% ) |
11.2KiB |
Bundle analysis report Branch fix/temp-switch-editor-mode-afte... Project dashboard
gbalint
approved these changes
Jul 9, 2024
Rheeseyb
approved these changes
Jul 9, 2024
…to fix/temp-switch-editor-mode-after-pane-select
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
## Problem While the pane selector dropdown is open, the canvas doesn't work (see https://screenshot.click/09-22-udhqg-wws23.mp4). To use the canvas, one needs to manually enter select mode again ## Fix Automatically enter select mode after a pane was opened
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While the pane selector dropdown is open, the canvas doesn't work (see https://screenshot.click/09-22-udhqg-wws23.mp4). To use the canvas, one needs to manually enter select mode again
Fix
Automatically enter select mode after a pane was opened