Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to select mode after opening pane #6048

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

bkrmendy
Copy link
Contributor

@bkrmendy bkrmendy commented Jul 9, 2024

Problem

While the pane selector dropdown is open, the canvas doesn't work (see https://screenshot.click/09-22-udhqg-wws23.mp4). To use the canvas, one needs to manually enter select mode again

Fix

Automatically enter select mode after a pane was opened

Copy link
Contributor

@balazsbajorics balazsbajorics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is still horrible

Copy link
Contributor

github-actions bot commented Jul 9, 2024

Try me

Copy link

relativeci bot commented Jul 9, 2024

#13291 Bundle Size — 62.51MiB (~+0.01%).

82eb959(current) vs 6339ece master#13283(baseline)

Warning

Bundle contains 51 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#13291
     Baseline
#13283
Regression  Initial JS 45.57MiB(~+0.01%) 45.57MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 21.62% 0%
No change  Chunks 30 30
No change  Assets 33 33
No change  Modules 4323 4323
No change  Duplicate Modules 524 524
No change  Duplicate Code 31.74% 31.74%
No change  Packages 450 450
No change  Duplicate Packages 51 51
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#13291
     Baseline
#13283
Regression  JS 62.5MiB (~+0.01%) 62.5MiB
Improvement  HTML 11.16KiB (-0.33%) 11.2KiB

Bundle analysis reportBranch fix/temp-switch-editor-mode-afte...Project dashboard

…to fix/temp-switch-editor-mode-after-pane-select
@bkrmendy bkrmendy merged commit 450c266 into master Jul 9, 2024
13 checks passed
@bkrmendy bkrmendy deleted the fix/temp-switch-editor-mode-after-pane-select branch July 9, 2024 14:07
liady pushed a commit that referenced this pull request Dec 13, 2024
## Problem
While the pane selector dropdown is open, the canvas doesn't work (see
https://screenshot.click/09-22-udhqg-wws23.mp4). To use the canvas, one
needs to manually enter select mode again

## Fix
Automatically enter select mode after a pane was opened
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants