Feat/animate grid #6046
Merged
Feat/animate grid #6046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # editor/src/components/canvas/controls/grid-controls.tsx
#13296 Bundle Size — 62.6MiB (+0.15%).
Warning Bundle contains 51 duplicate packages – View duplicate packages Bundle metrics
|
| Current #13296 |
Baseline #13292 |
|
|---|---|---|
 Initial JS |
45.66MiB(+0.2%) |
45.57MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
23.87% |
21.61% |
| Chunks |
30 |
30 |
| Assets |
33 |
33 |
| Modules |
4349(+0.6%) |
4323 |
| Duplicate Modules |
524 |
524 |
| Duplicate Code |
31.72%(-0.06%) |
31.74% |
| Packages |
450 |
450 |
| Duplicate Packages |
51 |
51 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #13296 |
Baseline #13292 |
|
|---|---|---|
| JS |
62.59MiB (+0.15%) |
62.5MiB |
| HTML |
11.16KiB (-0.33%) |
11.2KiB |
Bundle analysis report Branch feat/animate-grid Project dashboard
|
this is super slick. well done 👏 |
bkrmendy
approved these changes
Jul 9, 2024
liady
approved these changes
Jul 9, 2024
ruggi
commented
Jul 9, 2024
| @@ -1479,7 +1479,8 @@ describe('record variable values', () => { | |||
| }) | |||
|
|
|||
| describe('specialSizeMeasurements.globalFrameWithTextContent', () => { | |||
| it('includes the size of a contained text node', async () => { | |||
There was a problem hiding this comment.
cc @seanparsons for future reference
# Conflicts: # editor/src/core/model/element-metadata.spec.browser2.tsx
| @@ -516,7 +519,7 @@ export const EditorComponentInner = React.memo((props: EditorProps) => { | |||
| overflowX: 'hidden', | |||
| }} | |||
| > | |||
| <DesignPanelRoot /> | |||
| <DesignPanelRoot animationScope={props.animationScope} /> | |||
There was a problem hiding this comment.
why the prop drilling here? couldn't / shouldn't this be in a context? is props.animationScope referentially stable?
There was a problem hiding this comment.
what about this b60e41e ?
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** When rearranging grid elements, they should animate along the X/Y axii to indicate the completed movement. Moreover, we don't have a way to animate rendered canvas elements. **Fix:** This PR introduces a way to animate canvas elements programmatically, without having to inject anything inside the rendered components themselves. After doing that, the PR uses the new logic to animate the grid rearrange as a first test subject. The goal is to be able to arbitrarily animate canvas elements using the same framer motion API we use elsewhere, explicitly. In order to avoid manipulating the rendered elements, the targeting capabilities of `useAnimate` are used here. 1. Create the animation scope and animation function with `useAnimate` 2. Connect the scope with the `DesignPanelRoot` component 3. Store the animation function in a new `AnimationContext` context 4. `useCanvasAnimation` can now be used to target specific canvas elements and animate them, selecting them from the DOM by their `data-uid` prop 5. 🎈 https://github.com/concrete-utopia/utopia/assets/1081051/ab70b016-a91b-47f8-95ec-bec00bdca838
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When rearranging grid elements, they should animate along the X/Y axii to indicate the completed movement.
Moreover, we don't have a way to animate rendered canvas elements.
Fix:
This PR introduces a way to animate canvas elements programmatically, without having to inject anything inside the rendered components themselves. After doing that, the PR uses the new logic to animate the grid rearrange as a first test subject.
The goal is to be able to arbitrarily animate canvas elements using the same framer motion API we use elsewhere, explicitly. In order to avoid manipulating the rendered elements, the targeting capabilities of
useAnimateare used here.useAnimateDesignPanelRootcomponentAnimationContextcontextuseCanvasAnimationcan now be used to target specific canvas elements and animate them, selecting them from the DOM by theirdata-uidpropUntitled.mov