Hide absolute resize controls for grid cells #6043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#13269 Bundle Size — 62.51MiB (~+0.01%).
Warning Bundle contains 51 duplicate packages – View duplicate packages Bundle metrics
|
| Current #13269 |
Baseline #13264 |
|
|---|---|---|
 Initial JS |
45.56MiB(~+0.01%) |
45.56MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
21.62% |
21.84% |
| Chunks |
30 |
30 |
| Assets |
33 |
33 |
| Modules |
4323 |
4323 |
| Duplicate Modules |
524 |
524 |
| Duplicate Code |
31.74% |
31.74% |
| Packages |
450 |
450 |
| Duplicate Packages |
51 |
51 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #13269 |
Baseline #13264 |
|
|---|---|---|
| JS |
62.5MiB (~+0.01%) |
62.5MiB |
| HTML |
11.16KiB (-0.33%) |
11.2KiB |
Bundle analysis report Branch feat/hide-absolute-resize-grid-c... Project dashboard
gbalint
reviewed
Jul 8, 2024
| } | ||
| if (MetadataUtils.isGridCell(canvasState.startingMetadata, selectedElement)) { | ||
| return null | ||
| } |
There was a problem hiding this comment.
Don't you have to disable the other resize strategies (see https://github.com/concrete-utopia/utopia/blob/master/editor/src/components/canvas/canvas-strategies/canvas-strategies.tsx#L104 )?
bkrmendy
approved these changes
Jul 8, 2024
balazsbajorics
approved these changes
Jul 9, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** Absolute resize controls are shown when a grid cell is selected. **Fix:** Don't enable the absolute resize strategy when a grid cell is selected. **Note** With the upcoming cell resize feature we might want to add another case to `isResizableStrategy`, for which I left a comment in `canvas-strategies.tsx`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Absolute resize controls are shown when a grid cell is selected.
Fix:
Don't enable the absolute resize strategy when a grid cell is selected.
Note
With the upcoming cell resize feature we might want to add another case to
isResizableStrategy, for which I left a comment incanvas-strategies.tsx