Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove multiplayer feature switches #4803

Merged
merged 7 commits into from
Jan 30, 2024
Merged

Remove multiplayer feature switches #4803

merged 7 commits into from
Jan 30, 2024

Conversation

gbalint
Copy link
Contributor

@gbalint gbalint commented Jan 29, 2024

Description:
Remove the multiplayer related feature switches from the code.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 29, 2024 •
edited
Loading

Try me

@relativeci RelativeCI
Copy link

relativeci bot commented Jan 29, 2024 •
edited
Loading

Job #10106: Bundle Size — 62.4MiB (~+0.01%).

9151e9e(current) vs f73aa2d master#10100(baseline)

Warning

Bundle contains 66 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #10106		      Baseline
Job #10100
Regression  Initial JS 45.59MiB(~+0.01%) 45.59MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 21.67% 52.5%
No change  Chunks 26 26
No change  Assets 30 30
No change  Modules 4398 4398
No change  Duplicate Modules 477 477
No change  Duplicate Code 30.75% 30.75%
No change  Packages 462 462
No change  Duplicate Packages 65 65
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
Job #10106		      Baseline
Job #10100
Regression  JS 62.39MiB (~+0.01%) 62.38MiB
Improvement  HTML 11.5KiB (-0.3%) 11.54KiB

View job #10106 report View chore/remove-multiplayer-feature... branch activity View project dashboard

@gbalint gbalint marked this pull request as draft January 29, 2024 17:16
@github-actions GitHub Actions
Copy link
Contributor

Performance test results:

@github-actions GitHub Actions
Copy link
Contributor

Performance test results:

@github-actions GitHub Actions
Copy link
Contributor

Performance test results:

@gbalint gbalint marked this pull request as ready for review January 30, 2024 13:32
@gbalint gbalint merged commit 1b58932 into master Jan 30, 2024
11 of 12 checks passed
@gbalint gbalint deleted the chore/remove-multiplayer-feature-switches branch January 30, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkrmendy bkrmendy bkrmendy approved these changes

@ruggi ruggi ruggi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gbalint @ruggi @bkrmendy