Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert liveblocks thread metadata to our own typed representation #4798

Merged
merged 7 commits into from
Jan 26, 2024

Conversation

gbalint
Copy link
Contributor

@gbalint gbalint commented Jan 26, 2024

Problem:
Liveblocks does not allow us to create structured typing for the thread metadata.

Fix:

  • Create our own discriminated union based type system for threads.
  • Create conversion functions from liveblocks to utopia and the other way around
  • Create a converter from utopia to liveblocks for the partial types, which is useful for editing the metadata.

Copy link
Contributor

github-actions bot commented Jan 26, 2024

Try me

Copy link

relativeci bot commented Jan 26, 2024

Job #10073: Bundle Size — 62.39MiB (+0.01%).

22f3b2b(current) vs 4798d20 master#10069(baseline)

Warning

Bundle contains 66 duplicate packages – View duplicate packages

Bundle metrics  Change 4 changes Regression 2 regressions
                 Current
Job #10073
     Baseline
Job #10069
Regression  Initial JS 45.58MiB(+0.02%) 45.57MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 19.94% 0%
No change  Chunks 26 26
No change  Assets 30 30
Change  Modules 4398(+0.05%) 4396
Regression  Duplicate Modules 476(+0.21%) 475
No change  Duplicate Code 30.74% 30.74%
No change  Packages 462 462
No change  Duplicate Packages 65 65
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #10073
     Baseline
Job #10069
Regression  JS 62.37MiB (+0.01%) 62.37MiB
Not changed  HTML 11.54KiB 11.54KiB

View job #10073 reportView chore/refactor-thread-metadata-t... branch activityView project dashboard

editor/src/core/commenting/comment-types.tsx Outdated Show resolved Hide resolved
@gbalint gbalint merged commit 98414f1 into master Jan 26, 2024
13 of 14 checks passed
@gbalint gbalint deleted the chore/refactor-thread-metadata-type branch January 26, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants