More commenting test #4719
Merged
More commenting test #4719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruggi
approved these changes
Jan 10, 2024
| const BRANCH_NAME = process.env.BRANCH_NAME ? `&branch_name=${process.env.BRANCH_NAME}` : '' | ||
| const BASE_URL = process.env.BASE_URL ?? 'http://localhost:8000' | ||
|
|
||
| export async function init(utopiaBrowser: UtopiaPuppeteerBrowser) { |
There was a problem hiding this comment.
I think this would deserve a more specific name, e.g. initBrowserTest
Job #9833: Bundle Size — 62.24MiB (~+0.01%).
Warning Bundle contains 66 duplicate packages – View duplicate packages Bundle metrics
 
Bundle size by type
View job #9833 report View chore/commenting-tests branch activity |
bkrmendy
approved these changes
Jan 10, 2024
|
Performance test results: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I wrote a few tests for commenting.
I'm not decided on the general pattern on how to do it, because
BUT
So I wrote a longer test, which shows how we could write unified tests to test longer workflows, and I also wrote small tests, which only test a single feature. We can decide which pattern to follow.