Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update the empty comment sidebar copy #4694

Merged
merged 2 commits into from
Jan 8, 2024
Merged

update the empty comment sidebar copy #4694

merged 2 commits into from
Jan 8, 2024

Conversation

bkrmendy
Copy link
Contributor

@bkrmendy bkrmendy commented Jan 5, 2024

Update the empty sidebar copy to Use the commenting tool to leave comments on the canvas. They will also show up here.

@bkrmendy bkrmendy marked this pull request as draft January 5, 2024 12:48
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024 •
edited
Loading

Try me

@relativeci RelativeCI
Copy link

relativeci bot commented Jan 5, 2024 •
edited
Loading

Job #9734: Bundle Size — 62.19MiB (~+0.01%).

3c5b859(current) vs df0030c master#9731(baseline)

Warning

Bundle contains 66 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change Regression 1 regression
                 Current
Job #9734		      Baseline
Job #9731
Regression  Initial JS 45.4MiB(~+0.01%) 45.4MiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 19.86% 19.86%
No change  Chunks 26 26
No change  Assets 30 30
No change  Modules 4361 4361
No change  Duplicate Modules 470 470
No change  Duplicate Code 30.75% 30.75%
No change  Packages 462 462
No change  Duplicate Packages 65 65
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #9734		      Baseline
Job #9731
Regression  JS 62.18MiB (~+0.01%) 62.18MiB
Not changed  HTML 11.54KiB 11.54KiB

View job #9734 report View copy/leave-comments-copy branch activity

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024 •
edited
Loading

Performance test results:
(Chart1)
(Chart2)

@bkrmendy bkrmendy marked this pull request as ready for review January 5, 2024 13:03
@bkrmendy bkrmendy merged commit bd49c7f into master Jan 8, 2024
12 checks passed
@bkrmendy bkrmendy deleted the copy/leave-comments-copy branch January 8, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruggi ruggi ruggi approved these changes

@gbalint gbalint gbalint approved these changes

@seanparsons seanparsons Awaiting requested review from seanparsons

@Rheeseyb Rheeseyb Awaiting requested review from Rheeseyb

@balazsbajorics balazsbajorics Awaiting requested review from balazsbajorics

@liady liady Awaiting requested review from liady

@lankaukk lankaukk Awaiting requested review from lankaukk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkrmendy @gbalint @ruggi