Fix dark mode in portaled floating liveblocks elements #4691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbalint
requested review from
seanparsons,
Rheeseyb,
ruggi,
balazsbajorics,
liady and
bkrmendy
Job #9723: Bundle Size — 62.19MiB (~+0.01%).
Warning Bundle contains 66 duplicate packages – View duplicate packages Bundle metrics
 
Bundle size by type
View job #9723 report View fix/dark-mode-dropdown branch activity |
|
Performance test results: |
Rheeseyb
approved these changes
Jan 5, 2024
bkrmendy
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Portaled floating liveblocks elements (e.g. emoji menu, "More" menu to edit/delete comment, etc) are always shown in light mode:
Fix:
The problem is that we only set the
data-themeattribute on theCommentcomponent, and these floating elements are portaled to the end of the documen. The solution is to add thedata-themeattribute to the document body (and update when necessary).